LGTM, with a couple of tiny stylistic nits that I fixed before landing.
http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc File src/liveobjectlist.cc (right): http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode42 src/liveobjectlist.cc:42: #include "isolate.h" nit: please alphabetize includes. http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode1566 src/liveobjectlist.cc:1566: factory->NewJSObject(isolate->object_function()); indent 4 http://codereview.chromium.org/7398025/diff/1/src/liveobjectlist.cc#newcode1666 src/liveobjectlist.cc:1666: static_cast<int>(StringToInt(isolate->unicode_cache(), *address, 16)); nit: indentation -> 4 spaces http://codereview.chromium.org/7398025/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
