http://codereview.chromium.org/7686005/diff/1/src/api.cc File src/api.cc (right):
http://codereview.chromium.org/7686005/diff/1/src/api.cc#newcode4121 src/api.cc:4121: if (!EnsureInitializedForIsolate(isolate, "v8::Context::GetEntered()")) { On 2011/08/19 14:15:38, Vitaly Repeshko wrote:
While this will work, we could be a bit fancier here. If the isolate
is not
initialized, we can return an empty handle without trying to access
the handle
scope implementer.
The underlying problem is that r8833 changed our externally visible API semantics in very subtle ways, which already caused some breakage, e.g. Chrome 12 not working or http://code.google.com/p/v8/issues/detail?id=1597. I think that ensuring initialization here brings us closer back to our old semantics, so I am a bit reluctant to be "fancy" here. Another remark: What about other API functions in this file? I have the slightly uneasy feeling that similar problems will pop up later. This CL only fixes things enough that Chrome 12 works, but e.g. issue 1597 might imply that there is more to do... http://codereview.chromium.org/7686005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
