LGTM with comments addressed.
http://codereview.chromium.org/7634022/diff/4001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/7634022/diff/4001/src/hydrogen-instructions.cc#newcode886 src/hydrogen-instructions.cc:886: return input_range != NULL ? input_range->Copy() : HValue::InferRange(); It seems that if we are converting to integer type we can clear minus zero from resulting range. http://codereview.chromium.org/7634022/diff/4001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7634022/diff/4001/src/hydrogen.cc#newcode2328 src/hydrogen.cc:2328: graph()->InsertRepresentationChanges(); InsertRepresentationChange depends on kDeoptimizeOnUndefined flag which is propagated in MarkDeoptimizeOnUndefined phase. http://codereview.chromium.org/7634022/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
