Reviewers: jkummerow,
Message:
Fixed a really old regression in the V8 header at r5017.
http://code.google.com/p/v8/source/diff?spec=svn5017&r=5017&format=side&path=/trunk/include/v8.h&old_path=/trunk/include/v8.h&old=4924
When moving the V8EXPORT attribute from the class to each individual class
method, v8::Array::CheckCast and v8::Number::CheckCast has been left out. I
don't see any reason for this since for example v8::Date::CheckCast is
declared
V8EXPORT.
Description:
Added forgotten V8EXPORT attributes for v8::Array::CheckCast and
v8::Number::CheckCast.
BUG=v8:1618
Please review this at http://codereview.chromium.org/7692020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
e722d34e67762566bd3f65acfd3f5b02b35f53ac..46e4f0db0e3a6478605e2a02943dd994c468cb48
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1335,7 +1335,7 @@ class Number : public Primitive {
static inline Number* Cast(v8::Value* obj);
private:
V8EXPORT Number();
- static void CheckCast(v8::Value* obj);
+ V8EXPORT static void CheckCast(v8::Value* obj);
};
@@ -1709,7 +1709,7 @@ class Array : public Object {
static inline Array* Cast(Value* obj);
private:
V8EXPORT Array();
- static void CheckCast(Value* obj);
+ V8EXPORT static void CheckCast(Value* obj);
};
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
