http://restuta.net/clean-code/making-boolean-parameters-readable/ :-D
On Tue, Aug 23, 2011 at 09:48, <[email protected]> wrote: > Added new patch set. > > > > http://codereview.chromium.**org/7706004/diff/1/src/mark-**compact.cc<http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc> > File src/mark-compact.cc (left): > > http://codereview.chromium.**org/7706004/diff/1/src/mark-** > compact.cc#oldcode2615<http://codereview.chromium.org/7706004/diff/1/src/mark-compact.cc#oldcode2615> > src/mark-compact.cc:2615: PagedSpace* space = > static_cast<PagedSpace*>(p->**owner()); > On 2011/08/22 17:00:37, Vyacheslav Egorov wrote: > >> I prefer enums to booleans they make callsites clearer. >> > > Done. > > > http://codereview.chromium.**org/7706004/<http://codereview.chromium.org/7706004/> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
