LGTM
http://codereview.chromium.org/7709024/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7709024/diff/1/src/objects.h#newcode5901 src/objects.h:5901: FlatContent GetFlatContent(); This needs some documentation. A couple of optional ideas: 1. Take a pointer/reference to AssertNoAllocation as a parameter (similar to write barrier) to enforce valid usage. 2. Make this->IsFlat() a requirement, since this function doesn't flatten and the caller has to check whether the content is flat anyways. http://codereview.chromium.org/7709024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
