Addressed the comments. PTAL again.
http://codereview.chromium.org/7671042/diff/3001/src/contexts.cc File src/contexts.cc (right): http://codereview.chromium.org/7671042/diff/3001/src/contexts.cc#newcode98 src/contexts.cc:98: On 2011/08/23 08:36:12, fschneider wrote:
It's not so ideal to have the output parameter binding_flags
uninitialized on
some paths. I'd also initialize binding_flags to a default value as it
is done
for the other two parameters index and attributes.
Done. http://codereview.chromium.org/7671042/diff/3001/src/contexts.h File src/contexts.h (right): http://codereview.chromium.org/7671042/diff/3001/src/contexts.h#newcode379 src/contexts.h:379: BindingFlags* binding_flags); On 2011/08/23 08:36:12, fschneider wrote:
Reformat to make all parameters on a separate line.
Done. http://codereview.chromium.org/7671042/diff/3001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7671042/diff/3001/src/runtime.cc#newcode8568 src/runtime.cc:8568: Handle<Context> context = Handle<Context>(Context::cast(*holder)); On 2011/08/23 08:36:12, fschneider wrote:
I think you should rewrite this to avoid creating a new handle:
Handle<Context> context = Handle<Context>::cast(holder);
Done. http://codereview.chromium.org/7671042/diff/3001/test/mjsunit/harmony/block-let-semantics.js File test/mjsunit/harmony/block-let-semantics.js (right): http://codereview.chromium.org/7671042/diff/3001/test/mjsunit/harmony/block-let-semantics.js#newcode92 test/mjsunit/harmony/block-let-semantics.js:92: // initialized upon entering a function / block scope. On 2011/08/22 15:12:10, rossberg wrote:
Do we have tests that check that function declarations are not
actually hoisted
anymore, and that they see the inner scope?
Done. http://codereview.chromium.org/7671042/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
