Reviewers: jkummerow,

Message:
PTAL.


http://codereview.chromium.org/7717022/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7717022/diff/1/src/d8.cc#newcode1290
src/d8.cc:1290: OnExit();
Delete the pointer to the counters file only after V8 has been disposed.

Description:
Fixed minor bug in D8 related to mapping counters to a file.


Please review this at http://codereview.chromium.org/7717022/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/d8.cc


Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 780b0c0716e5d8b0dd4fc86197dc84fa0810d0ba..bba2feabf05013446288a2037756f01ea801b6f3 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1237,8 +1237,6 @@ int Shell::RunMain(int argc, char* argv[]) {
       thread->Join();
       delete thread;
     }
-
-  OnExit();
 #endif  // V8_SHARED
   return 0;
 }
@@ -1289,6 +1287,7 @@ int Shell::Main(int argc, char* argv[]) {
   }

   V8::Dispose();
+  OnExit();

   return result;
 }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to