http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right):
http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc#newcode3833 src/mips/code-stubs-mips.cc:3833: __ MultiPop((kCalleeSaved | ra.bit()) & ~sp.bit()); On 2011/08/25 10:50:51, fschneider wrote:
I guess you have to adjust the corresponding Multipop as well, right?
__ MultiPop((kCalleeSaved | ra.bit());
Yes, of course you're right. Leaving it didn't cause tests to fail (since we are removing sp.bit(), which was already removed from kCalleeSaved), which is how we missed it. But it makes the code look broken. Thanks for catching this. Fixed. http://codereview.chromium.org/7740018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
