On 2011/08/25 15:22:54, Vyacheslav Egorov wrote:
LGTM
Nice catch!
http://codereview.chromium.org/7744025/diff/1/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/7744025/diff/1/src/spaces.cc#newcode2779
src/spaces.cc:2779: Setup();
Calling Setup from TearDown is very confusing.
I thought so, too, but renaming it to something like "Reset" or "Clear"
makes
its call in Heap::Setup confusing. :-} But the latter call really change
anything at all, so in its current state it's superfluous. But with the
upcoming
GC merge, I don't think there is an urgent need for cosmetic changes in this
area...
http://codereview.chromium.org/7744025/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
