[v8-dev] [v8] r9024 committed - Changed the order of arguments in the check as suggested to issue 1275...

[codesite-noreply]

Revision: 9024
Author:   yang...@chromium.org
Date:     Fri Aug 26 01:45:47 2011
Log:      Changed the order of arguments in the check as suggested to issue  
1275.
BUG=v8:1275
Review URL: http://codereview.chromium.org/7740046
http://code.google.com/p/v8/source/detail?r=9024

Modified:
 /branches/bleeding_edge/test/cctest/test-api.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc     Thu Aug 25 06:22:55 2011
+++ /branches/bleeding_edge/test/cctest/test-api.cc     Fri Aug 26 01:45:47 2011
@@ -14452,34 +14452,34 @@
   v8::Handle<v8::RegExp> re = v8::RegExp::New(v8_str("foo"),  
v8::RegExp::kNone);
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("foo")));
-  CHECK_EQ(re->GetFlags(), v8::RegExp::kNone);
+  CHECK_EQ(v8::RegExp::kNone, re->GetFlags());

   re = v8::RegExp::New(v8_str("bar"),
                         
static_cast<v8::RegExp::Flags>(v8::RegExp::kIgnoreCase |
                                                        
v8::RegExp::kGlobal));
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("bar")));
-  CHECK_EQ(static_cast<int>(re->GetFlags()),
-           v8::RegExp::kIgnoreCase | v8::RegExp::kGlobal);
+  CHECK_EQ(v8::RegExp::kIgnoreCase | v8::RegExp::kGlobal,
+           static_cast<int>(re->GetFlags()));

   re = v8::RegExp::New(v8_str("baz"),
                         
static_cast<v8::RegExp::Flags>(v8::RegExp::kIgnoreCase |
                                                        
v8::RegExp::kMultiline));
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("baz")));
-  CHECK_EQ(static_cast<int>(re->GetFlags()),
-           v8::RegExp::kIgnoreCase | v8::RegExp::kMultiline);
+  CHECK_EQ(v8::RegExp::kIgnoreCase | v8::RegExp::kMultiline,
+           static_cast<int>(re->GetFlags()));

   re = CompileRun("/quux/").As<v8::RegExp>();
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("quux")));
-  CHECK_EQ(re->GetFlags(), v8::RegExp::kNone);
+  CHECK_EQ(v8::RegExp::kNone, re->GetFlags());

   re = CompileRun("/quux/gm").As<v8::RegExp>();
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("quux")));
-  CHECK_EQ(static_cast<int>(re->GetFlags()),
-           v8::RegExp::kGlobal | v8::RegExp::kMultiline);
+  CHECK_EQ(v8::RegExp::kGlobal | v8::RegExp::kMultiline,
+           static_cast<int>(re->GetFlags()));

   // Override the RegExp constructor and check the API constructor
   // still works.
@@ -14488,15 +14488,15 @@
   re = v8::RegExp::New(v8_str("foobar"), v8::RegExp::kNone);
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("foobar")));
-  CHECK_EQ(re->GetFlags(), v8::RegExp::kNone);
+  CHECK_EQ(v8::RegExp::kNone, re->GetFlags());

   re = v8::RegExp::New(v8_str("foobarbaz"),
                         
static_cast<v8::RegExp::Flags>(v8::RegExp::kIgnoreCase |
                                                        
v8::RegExp::kMultiline));
   CHECK(re->IsRegExp());
   CHECK(re->GetSource()->Equals(v8_str("foobarbaz")));
-  CHECK_EQ(static_cast<int>(re->GetFlags()),
-           v8::RegExp::kIgnoreCase | v8::RegExp::kMultiline);
+  CHECK_EQ(v8::RegExp::kIgnoreCase | v8::RegExp::kMultiline,
+           static_cast<int>(re->GetFlags()));

   context->Global()->Set(v8_str("re"), re);
   ExpectTrue("re.test('FoobarbaZ')");

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev