Reviewers: Sven,
Message:
Sven, sorry for the drive-by here, Søren suggested I submit to people
who "seem
to be around" until Danno gets back.... thanks in advance.
Description:
MIPS: Fixed a RecordWrite call in the FullCodeGenerator.
This caused an occasional failure in the Threading2 cctest running in debug
mode
with --always-opt.
BUG=
TEST=
Please review this at http://codereview.chromium.org/7779007/
Affected files:
M src/mips/full-codegen-mips.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
9bacac453afc56db420b450e090273b397537652..e387f16ee24c219d5252fe8ed45b7446ed250530
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -1533,9 +1533,7 @@ void
FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
// Update the write barrier for the array store with v0 as the scratch
// register.
- __ li(a2, Operand(offset));
- // TODO(PJ): double check this RecordWrite call.
- __ RecordWrite(a1, a2, result_register());
+ __ RecordWrite(a1, Operand(offset), a2, result_register());
PrepareForBailoutForId(expr->GetIdForElement(i), NO_REGISTERS);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
