Reviewers: Mikhail Naganov (Chromium),
Description:
Return v8::True or v8::False instead of using Boolean::New.
BUG=None
TEST=None
[email protected]
Signed-off-by: Thiago Farina <[email protected]>
Please review this at http://codereview.chromium.org/7785001/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M src/d8.cc
M test/cctest/test-api.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
120496eccce5921f887eafadf6ebd71e59867edc..025c7729170128aa691e299ae9aa433faf81630f
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -678,9 +678,9 @@ Handle<ObjectTemplate> Shell::CreateGlobalTemplate() {
FunctionTemplate::New(PixelArray));
#ifdef LIVE_OBJECT_LIST
- global_template->Set(String::New("lol_is_enabled"), Boolean::New(true));
+ global_template->Set(String::New("lol_is_enabled"), True());
#else
- global_template->Set(String::New("lol_is_enabled"), Boolean::New(false));
+ global_template->Set(String::New("lol_is_enabled"), False());
#endif
#ifndef V8_SHARED
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
aeb4cbe52298bd2a0751fbc60e3e1cf2fac55c39..891903655ee7a7d4d2c12558e3e6012574ed283c
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -823,7 +823,7 @@ static void* expected_ptr;
static v8::Handle<v8::Value> callback(const v8::Arguments& args) {
void* ptr = v8::External::Unwrap(args.Data());
CHECK_EQ(expected_ptr, ptr);
- return v8::Boolean::New(true);
+ return v8::True();
}
@@ -2609,7 +2609,7 @@ v8::Handle<Value> ThrowFromC(const v8::Arguments&
args) {
v8::Handle<Value> CCatcher(const v8::Arguments& args) {
- if (args.Length() < 1) return v8::Boolean::New(false);
+ if (args.Length() < 1) return v8::False();
v8::HandleScope scope;
v8::TryCatch try_catch;
Local<Value> result = v8::Script::Compile(args[0]->ToString())->Run();
@@ -7296,7 +7296,7 @@ THREADED_TEST(ConstructorForObject) {
CHECK(value->IsBoolean());
CHECK_EQ(true, value->BooleanValue());
- Handle<Value> args3[] = { v8::Boolean::New(true) };
+ Handle<Value> args3[] = { v8::True() };
Local<Value> value_obj3 = instance->CallAsConstructor(1, args3);
CHECK(value_obj3->IsObject());
Local<Object> object3 = Local<Object>::Cast(value_obj3);
@@ -9567,10 +9567,7 @@ THREADED_TEST(Overriding) {
static v8::Handle<Value> IsConstructHandler(const v8::Arguments& args) {
ApiTestFuzzer::Fuzz();
- if (args.IsConstructCall()) {
- return v8::Boolean::New(true);
- }
- return v8::Boolean::New(false);
+ return args.IsConstructCall() ? v8::True() : v8::False();
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
