LGTM, with one comment. What do you think about this? You are not going to remove v8::Boolean::New, right?
http://codereview.chromium.org/7785001/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7785001/diff/1/test/cctest/test-api.cc#newcode9570 test/cctest/test-api.cc:9570: return args.IsConstructCall() ? v8::True() : v8::False(); I believe, return v8::Boolean::New(args.IsConstructCall()) is more concise, and this is the case where v8::Boolean::New is useful. http://codereview.chromium.org/7785001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
