Revision: 9073 Author: [email protected] Date: Tue Aug 30 11:45:48 2011 Log: Return v8::True or v8::False instead of using Boolean::New.
BUG=None TEST=None [email protected] Signed-off-by: Thiago Farina <[email protected]> Review URL: http://codereview.chromium.org/7785001 http://code.google.com/p/v8/source/detail?r=9073 Modified: /branches/bleeding_edge/src/d8.cc /branches/bleeding_edge/test/cctest/test-api.cc ======================================= --- /branches/bleeding_edge/src/d8.cc Wed Aug 24 03:48:48 2011 +++ /branches/bleeding_edge/src/d8.cc Tue Aug 30 11:45:48 2011 @@ -678,9 +678,9 @@ FunctionTemplate::New(PixelArray)); #ifdef LIVE_OBJECT_LIST - global_template->Set(String::New("lol_is_enabled"), Boolean::New(true)); + global_template->Set(String::New("lol_is_enabled"), True()); #else - global_template->Set(String::New("lol_is_enabled"), Boolean::New(false)); + global_template->Set(String::New("lol_is_enabled"), False()); #endif #ifndef V8_SHARED ======================================= --- /branches/bleeding_edge/test/cctest/test-api.cc Fri Aug 26 06:53:00 2011 +++ /branches/bleeding_edge/test/cctest/test-api.cc Tue Aug 30 11:45:48 2011 @@ -823,7 +823,7 @@ static v8::Handle<v8::Value> callback(const v8::Arguments& args) { void* ptr = v8::External::Unwrap(args.Data()); CHECK_EQ(expected_ptr, ptr); - return v8::Boolean::New(true); + return v8::True(); } @@ -2609,7 +2609,7 @@ v8::Handle<Value> CCatcher(const v8::Arguments& args) { - if (args.Length() < 1) return v8::Boolean::New(false); + if (args.Length() < 1) return v8::False(); v8::HandleScope scope; v8::TryCatch try_catch; Local<Value> result = v8::Script::Compile(args[0]->ToString())->Run(); @@ -7296,7 +7296,7 @@ CHECK(value->IsBoolean()); CHECK_EQ(true, value->BooleanValue()); - Handle<Value> args3[] = { v8::Boolean::New(true) }; + Handle<Value> args3[] = { v8::True() }; Local<Value> value_obj3 = instance->CallAsConstructor(1, args3); CHECK(value_obj3->IsObject()); Local<Object> object3 = Local<Object>::Cast(value_obj3); @@ -9567,10 +9567,7 @@ static v8::Handle<Value> IsConstructHandler(const v8::Arguments& args) { ApiTestFuzzer::Fuzz(); - if (args.IsConstructCall()) { - return v8::Boolean::New(true); - } - return v8::Boolean::New(false); + return v8::Boolean::New(args.IsConstructCall()); } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
