Reviewers: Yang,
Message:
PTAL.
Description:
Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py
Please review this at http://codereview.chromium.org/7785025/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile
M tools/test-wrapper-gypbuild.py
Index: Makefile
diff --git a/Makefile b/Makefile
index
3008779bb34ecbd2b2080ac30021b40ddcc0d6e0..618bbef1d063956f2fcbc38535acc7778f5eb0e6
100644
--- a/Makefile
+++ b/Makefile
@@ -98,8 +98,9 @@ CHECKS = $(addsuffix .check,$(BUILDS))
# File where previously used GYPFLAGS are stored.
ENVFILE = $(OUTDIR)/environment
-.PHONY: all clean $(ENVFILE).new \
- $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES))
+.PHONY: all check clean $(ENVFILE).new \
+ $(ARCHES) $(MODES) $(BUILDS) $(CHECKS)
$(addsuffix .clean,$(ARCHES)) \
+ $(addsuffix .check,$(MODES)) $(addsuffix .check,$(ARCHES))
# Target definitions. "all" is the default.
all: $(MODES)
Index: tools/test-wrapper-gypbuild.py
diff --git a/tools/test-wrapper-gypbuild.py b/tools/test-wrapper-gypbuild.py
index
9bc6bf6ac7eef1fb3be5f1eae8e9c67b8daa6733..fdf825719272e78550e26559e8e4cba92bd6dfcc
100755
--- a/tools/test-wrapper-gypbuild.py
+++ b/tools/test-wrapper-gypbuild.py
@@ -53,6 +53,9 @@ def BuildOptions():
result.add_option("--outdir",
help='Base output directory',
default='out')
+ result.add_option("--no-presubmit",
+ help='Skip presubmit checks',
+ default=False, action="store_true")
# Flags this wrapper script handles itself:
result.add_option("-m", "--mode",
@@ -202,6 +205,11 @@ def Main():
return 1
workspace = abspath(join(dirname(sys.argv[0]), '..'))
+
+ if not options.no_presubmit:
+ print ">>> running presubmit tests"
+ subprocess.call([workspace + '/tools/presubmit.py'])
+
args_for_children = [workspace + '/tools/test.py'] +
PassOnOptions(options)
args_for_children += ['--no-build', '--build-system=gyp']
for arg in args:
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
