It needs the change we discussed (below). After that, LGTM.
http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7776009/diff/10001/src/hydrogen.cc#newcode2298 src/hydrogen.cc:2298: VisitDeclarations(scope->declarations()); There's an implicit declaration of the function name as a const, so you need something like: if (scope()->is_function_scope() && scope()->function() != NULL) { environmnent()->Bind(scope()->function(), <the hole value>); } before VisitDeclarations. http://codereview.chromium.org/7776009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
