Reviewers: Lasse Reichstein,

Message:
PTAL


http://codereview.chromium.org/7756014/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/7756014/diff/1/src/parser.cc#newcode4108
src/parser.cc:4108: ReportMessage("redeclaration", args);
This ReportMessage should rather be a ReportMessageAt. The proxy does
store a position but what is the correct way to turn it into a
Scanner::Location?

Description:
Detect conflicting variable bindings in harmony mode.

BUG=
TEST=mjsunit/harmony/block-conflicts.js


Please review this at http://codereview.chromium.org/7756014/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ast.h
  M src/ia32/full-codegen-ia32.cc
  M src/parser.h
  M src/parser.cc
  M src/scopes.h
  M src/scopes.cc
  A test/mjsunit/harmony/block-conflicts.js
  M test/mjsunit/harmony/block-let-declaration.js


--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to