LGTM.
We create the arguments object dynamically in the accessor, so not calling
the
accessor should be perfectly safe. There won't be anybody trying to update
the
property and failing.
I don't think there'll be any non-malicious code relying on
reading .arguments
of built-in functions.
http://codereview.chromium.org/7792054/diff/1/src/v8natives.js
File src/v8natives.js (right):
http://codereview.chromium.org/7792054/diff/1/src/v8natives.js#newcode58
src/v8natives.js:58: %IgnoreAttributesAndSetProperty(f, "caller",
Add comment that we don't match Safari, but we do match Firefox (and
possibly IE).
http://codereview.chromium.org/7792054/diff/1/src/v8natives.js#newcode64
src/v8natives.js:64:
Add a test that this works? E.g.,
[1].map(function() { assertEquals(null, [].map.caller);
assertEquals(null, [].map.arguments); }
http://codereview.chromium.org/7792054/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
