http://codereview.chromium.org/7736018/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/7736018/diff/1/src/arm/full-codegen-arm.cc#newcode777 src/arm/full-codegen-arm.cc:777: __ mov(r1, Operand(Smi::FromInt(is_eval() ? 1 : 0))); Absolutely. I'm amazed that it seemed to work. Fixed on Mips too. http://codereview.chromium.org/7736018/diff/1/src/messages.js File src/messages.js (right): http://codereview.chromium.org/7736018/diff/1/src/messages.js#newcode32 src/messages.js:32: const TYPE_NATIVE = 0; Nothing here is *necessary*, but it's an attempt to lock down the builtins object to prevent tampering in case someone gets a hold of it (i.e., security in depth). Making them macros.py-macros is a better idea. I do need some constants that can't be moved to macros.py, though (two of the vars below have been changed in another CL). Is there a better way to make them const than using "const" declarations? E.g., using %SetProperty(builtins, ...) ? http://codereview.chromium.org/7736018/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7736018/diff/1/src/runtime.cc#newcode1160 src/runtime.cc:1160: bool is_eval = (flags & kDeclareGlobalsEvalFlag) != 0; On 2011/09/01 07:58:24, Kevin Millikin wrote:
These flags and 'base' below are declared a away from where they're
used and
this is a big function. You might consider moving them down toward
their use. Done.
I also think it's clearer to make strict_mode a bool and only convert
it to the
enum at its single use.
The entire declaration of strict_mode is moved to just before it's used. http://codereview.chromium.org/7736018/diff/1/src/runtime.cc#newcode1246 src/runtime.cc:1246: PropertyAttributes attributes = Good idea. Done! http://codereview.chromium.org/7736018/diff/1/src/runtime.cc#newcode1275 src/runtime.cc:1275: attributes = static_cast<PropertyAttributes>( Done. http://codereview.chromium.org/7736018/diff/1/src/runtime.cc#newcode1278 src/runtime.cc:1278: RETURN_IF_EMPTY_HANDLE(isolate, Done. http://codereview.chromium.org/7736018/diff/1/src/v8globals.h File src/v8globals.h (right): http://codereview.chromium.org/7736018/diff/1/src/v8globals.h#newcode485 src/v8globals.h:485: kNonStrictMode = 0, Good catch. It's an artifact of a preliminary change that didn't make it. http://codereview.chromium.org/7736018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
