http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js File benchmarks/earley-boyer.js (right):
http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js#newcode2432 benchmarks/earley-boyer.js:2432: Is this a \t ?! http://codereview.chromium.org/7826007/diff/1/benchmarks/earley-boyer.js#newcode3075 benchmarks/earley-boyer.js:3075: Another \t http://codereview.chromium.org/7826007/diff/1/test/mjsunit/string-compare-alignment.js File test/mjsunit/string-compare-alignment.js (right): http://codereview.chromium.org/7826007/diff/1/test/mjsunit/string-compare-alignment.js#newcode32 test/mjsunit/string-compare-alignment.js:32: var base = "Now is the time for all good men to come to the aid of the party. " + While you're at it, fix the line length to 80 chars. http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py File tools/presubmit.py (right): http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode3 tools/presubmit.py:3: # Copyright 2008 the V8 project authors. All rights reserved. 2011 http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode234 tools/presubmit.py:234: Check that all files include a copyright notice and trailing whitespaces. you mean "and *no* trailing whitespace", right? http://codereview.chromium.org/7826007/diff/1/tools/presubmit.py#newcode276 tools/presubmit.py:276: if ' \n' in contents or contents.endswith(' '): The "contents.endswith(' ')" case isn't handled below. http://codereview.chromium.org/7826007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
