Excellent! I haven't looked too closely, but I have a few suggestions/feature requests:
1. Detecting the start revision based on ChangeLog could be the wrong revision (unlikely). It might be better to show the commit log for that push, ask if it's OK [Y/N] and quit the script if N; which brings me to: 2. It might be nice to allow (re)starting the script at various places that make sense (--upload-prepare when ChangeLog and version.cc have been modified, --commit-prepare when LGTM is received, etc....), in case a bit more manual intervention is required (updating changelog based on review comments, whatever). On Mon, Sep 5, 2011 at 5:35 PM, <[email protected]> wrote: > Reviewers: danno, > > Message: > PTAL. > > This is not tested with a real push to trunk yet, I have only performed a > dry-run (with all commands modifying server state being commented out). > > Description: > Introduce push-to-trunk.sh (for git users) > > > Please review this at > http://codereview.chromium.**org/7835035/<http://codereview.chromium.org/7835035/> > > SVN Base: > https://v8.googlecode.com/svn/**branches/bleeding_edge<https://v8.googlecode.com/svn/branches/bleeding_edge> > > Affected files: > A push-to-trunk.sh > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
