DBC

http://codereview.chromium.org/7835035/diff/1/push-to-trunk.sh
File push-to-trunk.sh (right):

http://codereview.chromium.org/7835035/diff/1/push-to-trunk.sh#newcode48
push-to-trunk.sh:48: if [ -n "$(git branch | grep $BRANCHNAME)" ] ; then
Perhaps, you need to check that this isn't the current branch, otherwise
deletion will fail.

http://codereview.chromium.org/7835035/diff/1/push-to-trunk.sh#newcode161
push-to-trunk.sh:161: git checkout -b $TRUNKBRANCH svn/trunk
Will fail if $TRUNKBRANCH already exists for some reason. If you don't
care to overwrite an existing branch, do "git branch -f $TRUNKBRANCH
svn/trunk"

http://codereview.chromium.org/7835035/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to