Reviewers: Jakob,
Message:
PTAL.
Description:
Presubmit output to distinguish check phases.
Please review this at http://codereview.chromium.org/7795050/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/presubmit.py
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index
50d2620162f4cf5a8e352a788b61ee2c72402a82..fda7ba96e5957a5b91c98f120af4c1708ed8c9a4
100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -311,13 +311,17 @@ class SourceProcessor(SourceFileProcessor):
def ProcessFiles(self, files, path):
success = True
+ violations = 0
for file in files:
try:
handle = open(file)
contents = handle.read()
- success = self.ProcessContents(file, contents) and success
+ if not self.ProcessContents(file, contents):
+ success = False
+ violations += 1
finally:
handle.close()
+ print "Total violating files: %s" % violations
return success
@@ -333,8 +337,10 @@ def Main():
parser = GetOptions()
(options, args) = parser.parse_args()
success = True
+ print "Running C++ lint check..."
if not options.no_lint:
success = CppLintProcessor().Run(workspace) and success
+ print "Running copyright header and trailing whitespaces check..."
success = SourceProcessor().Run(workspace) and success
if success:
return 0
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
