On 2011/08/30 00:51:01, Vitaly Repeshko wrote:
This need more work.
Even if we stop simplifying sliced strings when running out of memory
during
GC,
it can hurt other object types that can't tolerate allocation failures.
Whatever scheme we come up with should be memory efficient. In other
words,
simplifying slices should not increase total memory usage.
And as Erik points out this change can cause subtle bugs when a string
shape
is
changed after being inspected. Have you verified our runtime and generated
code
to be immune to this?
Thanks,
Vitaly
After reviewing the implementation in Firefox and doing some more testing, I
think leaving this as is would be the best option. Parent strings will be
kept
in the memory as long as slices that point to them stay alive, but the
chance of
doing that to a very long string is low and would not cause any problem.
http://codereview.chromium.org/7736020/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
