Revision: 9179 Author: [email protected] Date: Wed Sep 7 08:17:18 2011 Log: Presubmit output to distinguish check phases.
Review URL: http://codereview.chromium.org/7795050 http://code.google.com/p/v8/source/detail?r=9179 Modified: /branches/bleeding_edge/tools/presubmit.py ======================================= --- /branches/bleeding_edge/tools/presubmit.py Fri Sep 2 01:04:51 2011 +++ /branches/bleeding_edge/tools/presubmit.py Wed Sep 7 08:17:18 2011 @@ -311,13 +311,17 @@ def ProcessFiles(self, files, path): success = True + violations = 0 for file in files: try: handle = open(file) contents = handle.read() - success = self.ProcessContents(file, contents) and success + if not self.ProcessContents(file, contents): + success = False + violations += 1 finally: handle.close() + print "Total violating files: %s" % violations return success @@ -333,8 +337,10 @@ parser = GetOptions() (options, args) = parser.parse_args() success = True + print "Running C++ lint check..." if not options.no_lint: success = CppLintProcessor().Run(workspace) and success + print "Running copyright header and trailing whitespaces check..." success = SourceProcessor().Run(workspace) and success if success: return 0 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
