LGTM with nits.Go read http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml. All of
it.
http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc#newcode2526 src/runtime.cc:2526: int IsSimple() { nit 1: This is C++. We have bools. nit 2: A simple getter for my_favorite_variable_ is typically called my_favorite_variable(), so in this case "simple_hint()". http://codereview.chromium.org/7839031/diff/2002/src/runtime.cc#newcode2697 src/runtime.cc:2697: bool simple_hint; nit: trailing underscore please http://codereview.chromium.org/7839031/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
