http://codereview.chromium.org/7839030/diff/2001/src/debug.cc File src/debug.cc (right):
http://codereview.chromium.org/7839030/diff/2001/src/debug.cc#newcode1686 src/debug.cc:1686: bool SortedListContains(List<JSFunction*>* functions, JSFunction* function) { Perhaps this should be moved to the List template class, probably with a different signature (something like C's bsearch) http://codereview.chromium.org/7839030/diff/2001/src/debug.cc#newcode1720 src/debug.cc:1720: List<JSFunction*> functions(100); functions => active_functions http://codereview.chromium.org/7839030/diff/2001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7839030/diff/2001/src/objects-inl.h#newcode2950 src/objects-inl.h:2950: kFullCodeFlagsHasDeoptimizationSupportShift) == 1; Why do we need both a mask and a shift? A single bit mask/flag (whatever you call it) seems to be sufficient. Same for other places like this below. http://codereview.chromium.org/7839030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
