LGTM
http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc#newcode2186 src/mark-compact.cc:2186: SKIP_WRITE_BARRIER);//Is this OK? Yes it is we are in the middle of the GC so all incremental activities are stopped. http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc#newcode2195 src/mark-compact.cc:2195: // The undefined object is on a page that is never compacted and never And it's also root. And we are in the middle of GC http://codereview.chromium.org/7846014/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7846014/diff/1/src/runtime.cc#newcode6082 src/runtime.cc:6082: ASSERT(!heap->InNewSpace(value)); I think this assertion is not required any more. http://codereview.chromium.org/7846014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
