Revision: 9196
Author:   [email protected]
Date:     Thu Sep  8 06:20:49 2011
Log:      Add "soname_version" parameter to common.gypi, v8.gyp, Makefile

TEST=compile with component=shared_library and soname_version=1.2.3 and find "libv8-1.2.3.so" in the output.

Review URL: http://codereview.chromium.org/7848017
http://code.google.com/p/v8/source/detail?r=9196

Modified:
 /branches/bleeding_edge/Makefile
 /branches/bleeding_edge/build/common.gypi
 /branches/bleeding_edge/tools/gyp/v8.gyp

=======================================
--- /branches/bleeding_edge/Makefile    Wed Sep  7 06:48:29 2011
+++ /branches/bleeding_edge/Makefile    Thu Sep  8 06:20:49 2011
@@ -68,6 +68,10 @@
 else
   GYPFLAGS += -Dv8_can_use_vfp_instructions=true
 endif
+# soname_version=1.2.3
+ifdef soname_version
+  GYPFLAGS += -Dsoname_version=$(soname_version)
+endif

 # ----------------- available targets: --------------------
 # - "dependencies": pulls in external dependencies (currently: GYP)
=======================================
--- /branches/bleeding_edge/build/common.gypi   Thu Sep  1 04:50:29 2011
+++ /branches/bleeding_edge/build/common.gypi   Thu Sep  8 06:20:49 2011
@@ -72,6 +72,9 @@
     'v8_use_snapshot%': 'true',
     'host_os%': '<(OS)',
     'v8_use_liveobjectlist%': 'false',
+
+    # For a shared library build, results in "libv8-<(soname_version).so".
+    'soname_version%': '',
   },
   'target_defaults': {
     'conditions': [
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp    Thu Sep  8 06:06:44 2011
+++ /branches/bleeding_edge/tools/gyp/v8.gyp    Thu Sep  8 06:20:49 2011
@@ -70,6 +70,13 @@
                       'V8_SHARED',
                     ],
                   },
+                }],
+                ['soname_version!=""', {
+                  # Ideally, we'd like to specify the full filename for the
+                  # library and set it to "libv8.so.<(soname_version)",
+ # but currently the best we can do is use 'product_name' and
+                  # get "libv8-<(soname_version).so".
+                  'product_name': 'v8-<(soname_version)',
                 }],
               ],
             },

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to