Reviewers: Søren Gjesse,

Message:
Please, take a look.

PS: Please, keep the signed-off line if everything is ok when committing.

Copying Mikhail as he committed some patches to me.

Thanks!

Description:
Fix memory leak from debug.cc

We were not disposing debugger_access_ when Debug is destroyed.

BUG=v8:518

[email protected]

Signed-off-by: Thiago Farina <[email protected]>


Please review this at http://codereview.chromium.org/7848026/

SVN Base: git://github.com/v8/v8.git@master

Affected files:
  M src/debug.cc


Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 2d58ce1f54aefba1e93be618b9a1f76a69f7bcd3..2cb76c16a232b9337539f8d57bf851bda438d299 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -1987,6 +1987,8 @@ Debugger::Debugger(Isolate* isolate)


 Debugger::~Debugger() {
+  delete debugger_access_;
+  debugger_access_ = 0;
   delete dispatch_handler_access_;
   dispatch_handler_access_ = 0;
   delete command_received_;


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to