On 2011/09/08 17:31:17, tfarina wrote:
On 2011/09/08 17:29:05, Vitaly Repeshko wrote:
> On 2011/09/08 13:56:43, Mikhail Naganov (Chromium) wrote:
> > On 2011/09/08 13:19:21, tfarina wrote:
> > > On 2011/09/08 12:42:44, Mikhail Naganov (Chromium) wrote:
> > > > On 2011/09/08 01:30:56, tfarina wrote:
> > > >
> > > > What about thread_? It doesn't seem to delete itself as well.
> > >
> > > Done.
> >
> > LGTM, landed.
>
> SmartPointer should have been named SmartArrayPointer as it expects an
input
> allocated using new[] and deallocates it using delete[]. Using it as a
simple
> scoped pointer for a single object is incorrect.
D'oh, I'll fix this. I'll change from SmartPointer to plain delete
instead. :(
Thanks.
Is it worth sending a patch for renaming to SmartArrayPointer?
Yes, I think so.
http://codereview.chromium.org/7754007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
