Reviewers: Erik Corry,
Description:
Fix presubmit errors caused by updated depot tools
This is all blank line before/after linting errors.
Please review this at http://codereview.chromium.org/7754022/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M samples/process.cc
M src/accessors.cc
M src/arguments.h
M src/arm/lithium-gap-resolver-arm.h
M src/arm/regexp-macro-assembler-arm.h
M src/bignum.h
M src/cached-powers.h
M src/compilation-cache.h
M src/d8-posix.cc
M src/d8.h
M src/dateparser.h
M src/debug.h
M src/frames.h
M src/ia32/assembler-ia32.h
M src/inspector.h
M src/jsregexp.h
M src/list.h
M src/liveobjectlist.h
M src/log-utils.h
M src/mips/assembler-mips.h
M src/mips/regexp-macro-assembler-mips.h
M src/objects.h
M src/platform-cygwin.cc
M src/platform-freebsd.cc
M src/platform-macos.cc
M src/platform-solaris.cc
M src/regexp-macro-assembler-irregexp.h
M src/regexp-macro-assembler-tracer.h
M src/regexp-stack.h
M src/scanner.h
M src/scopeinfo.h
M src/spaces.h
M src/splay-tree.h
M src/string-stream.h
M src/utils.h
M src/v8threads.h
M src/x64/assembler-x64.h
M test/cctest/cctest.h
M test/cctest/test-debug.cc
M test/cctest/test-lockers.cc
M test/cctest/test-threads.cc
Index: samples/process.cc
===================================================================
--- samples/process.cc (revision 9202)
+++ samples/process.cc (working copy)
@@ -77,7 +77,6 @@
*/
class JsHttpRequestProcessor : public HttpRequestProcessor {
public:
-
// Creates a new processor that processes requests by invoking the
// Process function of the JavaScript script given as an argument.
explicit JsHttpRequestProcessor(Handle<String> script) : script_(script)
{ }
@@ -88,7 +87,6 @@
virtual bool Process(HttpRequest* req);
private:
-
// Execute the script associated with this processor and extract the
// Process function. Returns true if this succeeded, otherwise false.
bool ExecuteScript(Handle<String> script);
Index: src/accessors.cc
===================================================================
--- src/accessors.cc (revision 9202)
+++ src/accessors.cc (working copy)
@@ -710,6 +710,7 @@
} while (next_function != NULL);
return false;
}
+
private:
void GetFunctions() {
functions_.Rewind(0);
Index: src/arguments.h
===================================================================
--- src/arguments.h (revision 9202)
+++ src/arguments.h (working copy)
@@ -75,6 +75,7 @@
int length() const { return length_; }
Object** arguments() { return arguments_; }
+
private:
int length_;
Object** arguments_;
Index: src/arm/lithium-gap-resolver-arm.h
===================================================================
--- src/arm/lithium-gap-resolver-arm.h (revision 9202)
+++ src/arm/lithium-gap-resolver-arm.h (working copy)
@@ -40,7 +40,6 @@
class LGapResolver BASE_EMBEDDED {
public:
-
explicit LGapResolver(LCodeGen* owner);
// Resolve a set of parallel moves, emitting assembler instructions.
Index: src/arm/regexp-macro-assembler-arm.h
===================================================================
--- src/arm/regexp-macro-assembler-arm.h (revision 9202)
+++ src/arm/regexp-macro-assembler-arm.h (working copy)
@@ -116,6 +116,7 @@
static int CheckStackGuardState(Address* return_address,
Code* re_code,
Address re_frame);
+
private:
// Offsets from frame_pointer() of function parameters and stored
registers.
static const int kFramePointer = 0;
Index: src/bignum.h
===================================================================
--- src/bignum.h (revision 9202)
+++ src/bignum.h (working copy)
@@ -92,6 +92,7 @@
static bool PlusLess(const Bignum& a, const Bignum& b, const Bignum& c) {
return PlusCompare(a, b, c) < 0;
}
+
private:
typedef uint32_t Chunk;
typedef uint64_t DoubleChunk;
Index: src/cached-powers.h
===================================================================
--- src/cached-powers.h (revision 9202)
+++ src/cached-powers.h (working copy)
@@ -35,7 +35,6 @@
class PowersOfTenCache {
public:
-
// Not all powers of ten are cached. The decimal exponent of two
neighboring
// cached numbers will differ by kDecimalExponentDistance.
static const int kDecimalExponentDistance;
Index: src/compilation-cache.h
===================================================================
--- src/compilation-cache.h (revision 9202)
+++ src/compilation-cache.h (working copy)
@@ -242,6 +242,7 @@
// cache during debugging to make sure new scripts are always compiled.
void Enable();
void Disable();
+
private:
explicit CompilationCache(Isolate* isolate);
~CompilationCache();
Index: src/d8-posix.cc
===================================================================
--- src/d8-posix.cc (revision 9202)
+++ src/d8-posix.cc (working copy)
@@ -231,6 +231,7 @@
static const unsigned kMaxArgs = 1000;
char** arg_array() { return exec_args_; }
char* arg0() { return exec_args_[0]; }
+
private:
char* exec_args_[kMaxArgs + 1];
};
Index: src/d8.h
===================================================================
--- src/d8.h (revision 9202)
+++ src/d8.h (working copy)
@@ -208,6 +208,7 @@
#else
class Shell : public i::AllStatic {
#endif // V8_SHARED
+
public:
static bool ExecuteString(Handle<String> source,
Handle<Value> name,
Index: src/dateparser.h
===================================================================
--- src/dateparser.h (revision 9202)
+++ src/dateparser.h (working copy)
@@ -36,7 +36,6 @@
class DateParser : public AllStatic {
public:
-
// Parse the string as a date. If parsing succeeds, return true after
// filling out the output array as follows (all integers are Smis):
// [0]: year
@@ -234,6 +233,7 @@
static DateToken Invalid() {
return DateToken(kInvalidTokenTag, 0, -1);
}
+
private:
enum TagType {
kInvalidTokenTag = -6,
@@ -275,6 +275,7 @@
}
return false;
}
+
private:
DateToken Scan();
@@ -351,6 +352,7 @@
static bool IsMinute(int x) { return Between(x, 0, 59); }
static bool IsHour(int x) { return Between(x, 0, 23); }
static bool IsSecond(int x) { return Between(x, 0, 59); }
+
private:
static bool IsHour12(int x) { return Between(x, 0, 12); }
static bool IsMillisecond(int x) { return Between(x, 0, 999); }
Index: src/debug.h
===================================================================
--- src/debug.h (revision 9202)
+++ src/debug.h (working copy)
@@ -1026,6 +1026,7 @@
return NULL;
}
}
+
private:
Debug::AddressId id_;
};
Index: src/frames.h
===================================================================
--- src/frames.h (revision 9202)
+++ src/frames.h (working copy)
@@ -579,6 +579,7 @@
virtual void Print(StringStream* accumulator,
PrintMode mode,
int index) const;
+
protected:
explicit ArgumentsAdaptorFrame(StackFrameIterator* iterator)
: JavaScriptFrame(iterator) { }
Index: src/ia32/assembler-ia32.h
===================================================================
--- src/ia32/assembler-ia32.h (revision 9202)
+++ src/ia32/assembler-ia32.h (working copy)
@@ -465,6 +465,7 @@
// Enable a specified feature within a scope.
class Scope BASE_EMBEDDED {
#ifdef DEBUG
+
public:
explicit Scope(CpuFeature f) {
uint64_t mask = static_cast<uint64_t>(1) << f;
@@ -484,10 +485,12 @@
isolate_->set_enabled_cpu_features(old_enabled_);
}
}
+
private:
Isolate* isolate_;
uint64_t old_enabled_;
#else
+
public:
explicit Scope(CpuFeature f) {}
#endif
Index: src/inspector.h
===================================================================
--- src/inspector.h (revision 9202)
+++ src/inspector.h (working copy)
@@ -41,7 +41,6 @@
class Inspector {
public:
-
static void DumpObjectType(FILE* out, Object *obj, bool print_more);
static void DumpObjectType(FILE* out, Object *obj) {
DumpObjectType(out, obj, false);
@@ -59,4 +58,3 @@
#endif // INSPECTOR
#endif // V8_INSPECTOR_H_
-
Index: src/jsregexp.h
===================================================================
--- src/jsregexp.h (revision 9202)
+++ src/jsregexp.h (working copy)
@@ -255,6 +255,7 @@
return (bits_ == (kInFirst | kInSecond | kInBoth));
}
int value() { return bits_; }
+
private:
int bits_;
};
@@ -404,6 +405,7 @@
template <typename Callback>
void ForEach(Callback* callback) { return tree()->ForEach(callback); }
+
private:
// There can't be a static empty set since it allocates its
// successors in a zone and caches them.
@@ -793,6 +795,7 @@
virtual int GreedyLoopTextLength() { return
kNodeIsTooComplexForGreedyLoops; }
virtual ActionNode* Clone() { return new ActionNode(*this); }
virtual int ComputeFirstCharacterSet(int budget);
+
private:
union {
struct {
@@ -861,6 +864,7 @@
}
void CalculateOffsets();
virtual int ComputeFirstCharacterSet(int budget);
+
private:
enum TextEmitPassType {
NON_ASCII_MATCH, // Check for characters that can't match.
@@ -925,6 +929,7 @@
virtual AssertionNode* Clone() { return new AssertionNode(*this); }
AssertionNodeType type() { return type_; }
void set_type(AssertionNodeType type) { type_ = type; }
+
private:
AssertionNode(AssertionNodeType t, RegExpNode* on_success)
: SeqRegExpNode(on_success), type_(t) { }
@@ -955,6 +960,7 @@
}
virtual BackReferenceNode* Clone() { return new
BackReferenceNode(*this); }
virtual int ComputeFirstCharacterSet(int budget);
+
private:
int start_reg_;
int end_reg_;
@@ -1301,6 +1307,7 @@
}
void InvalidateCurrentCharacter();
void AdvanceCurrentPositionInTrace(int by, RegExpCompiler* compiler);
+
private:
int FindAffectedRegisters(OutSet* affected_registers);
void PerformDeferredActions(RegExpMacroAssembler* macro,
@@ -1402,6 +1409,7 @@
void fail(const char* error_message) {
error_message_ = error_message;
}
+
private:
bool ignore_case_;
bool is_ascii_;
Index: src/list.h
===================================================================
--- src/list.h (revision 9202)
+++ src/list.h (working copy)
@@ -49,7 +49,6 @@
template <typename T, class P>
class List {
public:
-
List() { Initialize(0); }
INLINE(explicit List(int capacity)) { Initialize(capacity); }
INLINE(~List()) { DeleteData(data_); }
Index: src/liveobjectlist.h
===================================================================
--- src/liveobjectlist.h (revision 9202)
+++ src/liveobjectlist.h (working copy)
@@ -114,7 +114,6 @@
static Object* PrintObj(int obj_id);
private:
-
struct Element {
int id_;
HeapObject* obj_;
@@ -224,7 +223,6 @@
// Helper class for updating the LiveObjectList HeapObject pointers.
class UpdateLiveObjectListVisitor: public ObjectVisitor {
public:
-
void VisitPointer(Object** p) { UpdatePointer(p); }
void VisitPointers(Object** start, Object** end) {
@@ -319,4 +317,3 @@
} } // namespace v8::internal
#endif // V8_LIVEOBJECTLIST_H_
-
Index: src/log-utils.h
===================================================================
--- src/log-utils.h (revision 9202)
+++ src/log-utils.h (working copy)
@@ -141,7 +141,6 @@
void WriteToLogFile();
private:
-
Log* log_;
ScopedLock sl;
int pos_;
Index: src/mips/assembler-mips.h
===================================================================
--- src/mips/assembler-mips.h (revision 9202)
+++ src/mips/assembler-mips.h (working copy)
@@ -1159,6 +1159,7 @@
}
return trampoline_slot;
}
+
private:
int start_;
int end_;
Index: src/mips/regexp-macro-assembler-mips.h
===================================================================
--- src/mips/regexp-macro-assembler-mips.h (revision 9202)
+++ src/mips/regexp-macro-assembler-mips.h (working copy)
@@ -118,6 +118,7 @@
static int CheckStackGuardState(Address* return_address,
Code* re_code,
Address re_frame);
+
private:
// Offsets from frame_pointer() of function parameters and stored
registers.
static const int kFramePointer = 0;
Index: src/objects.h
===================================================================
--- src/objects.h (revision 9202)
+++ src/objects.h (working copy)
@@ -3154,7 +3154,6 @@
// raised rather than being silently ignored.
class ExternalArray: public FixedArrayBase {
public:
-
inline bool is_the_hole(int index) { return false; }
// [external_pointer]: The pointer to the external memory area backing
this
@@ -6409,7 +6408,6 @@
// - truncating sliced string to enable otherwise unneeded parent to be
GC'ed.
class SlicedString: public String {
public:
-
inline String* parent();
inline void set_parent(String* parent);
inline int offset();
Index: src/platform-cygwin.cc
===================================================================
--- src/platform-cygwin.cc (revision 9202)
+++ src/platform-cygwin.cc (working copy)
@@ -474,7 +474,6 @@
class CygwinMutex : public Mutex {
public:
-
CygwinMutex() {
pthread_mutexattr_t attrs;
memset(&attrs, 0, sizeof(attrs));
Index: src/platform-freebsd.cc
===================================================================
--- src/platform-freebsd.cc (revision 9202)
+++ src/platform-freebsd.cc (working copy)
@@ -471,7 +471,6 @@
class FreeBSDMutex : public Mutex {
public:
-
FreeBSDMutex() {
pthread_mutexattr_t attrs;
int result = pthread_mutexattr_init(&attrs);
Index: src/platform-macos.cc
===================================================================
--- src/platform-macos.cc (revision 9202)
+++ src/platform-macos.cc (working copy)
@@ -558,7 +558,6 @@
class MacOSMutex : public Mutex {
public:
-
MacOSMutex() {
pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr);
Index: src/platform-solaris.cc
===================================================================
--- src/platform-solaris.cc (revision 9202)
+++ src/platform-solaris.cc (working copy)
@@ -460,7 +460,6 @@
class SolarisMutex : public Mutex {
public:
-
SolarisMutex() {
pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr);
Index: src/regexp-macro-assembler-irregexp.h
===================================================================
--- src/regexp-macro-assembler-irregexp.h (revision 9202)
+++ src/regexp-macro-assembler-irregexp.h (working copy)
@@ -107,6 +107,7 @@
virtual IrregexpImplementation Implementation();
virtual Handle<HeapObject> GetCode(Handle<String> source);
+
private:
void Expand();
// Code and bitmap emission.
Index: src/regexp-macro-assembler-tracer.h
===================================================================
--- src/regexp-macro-assembler-tracer.h (revision 9202)
+++ src/regexp-macro-assembler-tracer.h (working copy)
@@ -95,6 +95,7 @@
virtual void WriteCurrentPositionToRegister(int reg, int cp_offset);
virtual void ClearRegisters(int reg_from, int reg_to);
virtual void WriteStackPointerToRegister(int reg);
+
private:
RegExpMacroAssembler* assembler_;
};
Index: src/regexp-stack.h
===================================================================
--- src/regexp-stack.h (revision 9202)
+++ src/regexp-stack.h (working copy)
@@ -89,6 +89,7 @@
char* ArchiveStack(char* to);
char* RestoreStack(char* from);
void FreeThreadResources() { thread_local_.Free(); }
+
private:
RegExpStack();
~RegExpStack();
Index: src/scanner.h
===================================================================
--- src/scanner.h (revision 9202)
+++ src/scanner.h (working copy)
@@ -135,7 +135,6 @@
bool IsWhiteSpace(unibrow::uchar c) { return kIsWhiteSpace.get(c); }
private:
-
unibrow::Predicate<IdentifierStart, 128> kIsIdentifierStart;
unibrow::Predicate<IdentifierPart, 128> kIsIdentifierPart;
unibrow::Predicate<unibrow::LineTerminator, 128> kIsLineTerminator;
@@ -198,6 +197,7 @@
position_ = 0;
is_ascii_ = true;
}
+
private:
static const int kInitialCapacity = 16;
static const int kGrowthFactory = 4;
Index: src/scopeinfo.h
===================================================================
--- src/scopeinfo.h (revision 9202)
+++ src/scopeinfo.h (working copy)
@@ -156,7 +156,6 @@
static SerializedScopeInfo* Empty();
private:
-
inline Object** ContextEntriesAddr();
inline Object** ParameterEntriesAddr();
@@ -187,6 +186,7 @@
void Clear();
static const int kNotFound = -2;
+
private:
ContextSlotCache() {
for (int i = 0; i < kLength; ++i) {
Index: src/spaces.h
===================================================================
--- src/spaces.h (revision 9202)
+++ src/spaces.h (working copy)
@@ -1232,8 +1232,8 @@
// Returns the number of total pages in this space.
int CountTotalPages();
#endif
- private:
+ private:
// Returns a pointer to the page of the relocation pointer.
Page* MCRelocationTopPage() { return TopPageOf(mc_forwarding_info_); }
@@ -1816,7 +1816,6 @@
void MarkNodes();
private:
-
Heap* heap_;
// Available bytes on the free list.
Index: src/splay-tree.h
===================================================================
--- src/splay-tree.h (revision 9202)
+++ src/splay-tree.h (working copy)
@@ -123,8 +123,8 @@
Value value() { return value_; }
Node* left() { return left_; }
Node* right() { return right_; }
- private:
+ private:
friend class SplayTree;
friend class Locator;
Key key_;
@@ -143,6 +143,7 @@
Value& value() { return node_->value_; }
void set_value(const Value& value) { node_->value_ = value; }
inline void bind(Node* node) { node_ = node; }
+
private:
Node* node_;
};
@@ -151,7 +152,6 @@
void ForEach(Callback* callback);
protected:
-
// Resets tree root. Existing nodes become unreachable.
void ResetRoot() { root_ = NULL; }
@@ -187,7 +187,6 @@
void Call(Node* node) { delete node; }
private:
-
DISALLOW_COPY_AND_ASSIGN(NodeDeleter);
};
Index: src/string-stream.h
===================================================================
--- src/string-stream.h (revision 9202)
+++ src/string-stream.h (working copy)
@@ -93,6 +93,7 @@
FmtElm(void* value) : type_(POINTER) { // NOLINT
data_.u_pointer_ = value;
}
+
private:
friend class StringStream;
enum Type { INT, DOUBLE, C_STR, LC_STR, OBJ, HANDLE, POINTER };
Index: src/utils.h
===================================================================
--- src/utils.h (revision 9202)
+++ src/utils.h (working copy)
@@ -890,6 +890,7 @@
int position_;
bool is_finalized() const { return position_ < 0; }
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(SimpleStringBuilder);
};
Index: src/v8threads.h
===================================================================
--- src/v8threads.h (revision 9202)
+++ src/v8threads.h (working copy)
@@ -54,6 +54,7 @@
// Get data area for archiving a thread.
char* data() { return data_; }
+
private:
explicit ThreadState(ThreadManager* thread_manager);
Index: src/x64/assembler-x64.h
===================================================================
--- src/x64/assembler-x64.h (revision 9202)
+++ src/x64/assembler-x64.h (working copy)
@@ -453,6 +453,7 @@
// Enable a specified feature within a scope.
class Scope BASE_EMBEDDED {
#ifdef DEBUG
+
public:
explicit Scope(CpuFeature f) {
uint64_t mask = V8_UINT64_C(1) << f;
@@ -472,10 +473,12 @@
isolate_->set_enabled_cpu_features(old_enabled_);
}
}
+
private:
Isolate* isolate_;
uint64_t old_enabled_;
#else
+
public:
explicit Scope(CpuFeature f) {}
#endif
Index: test/cctest/cctest.h
===================================================================
--- test/cctest/cctest.h (revision 9202)
+++ test/cctest/cctest.h (working copy)
@@ -110,6 +110,7 @@
// This method switches threads if we are running the Threading test.
// Otherwise it does nothing.
static void Fuzz();
+
private:
static bool fuzzing_;
static int tests_being_run_;
Index: test/cctest/test-debug.cc
===================================================================
--- test/cctest/test-debug.cc (revision 9202)
+++ test/cctest/test-debug.cc (working copy)
@@ -157,6 +157,7 @@
Handle<Object>(debug->debug_context()->global_proxy()), DONT_ENUM,
::v8::internal::kNonStrictMode);
}
+
private:
v8::Persistent<v8::Context> context_;
};
Index: test/cctest/test-lockers.cc
===================================================================
--- test/cctest/test-lockers.cc (revision 9202)
+++ test/cctest/test-lockers.cc (working copy)
@@ -142,6 +142,7 @@
}
virtual void Run() = 0;
+
private:
class ThreadWithSemaphore : public i::Thread {
public:
@@ -377,6 +378,7 @@
CalcFibAndCheck();
}
}
+
private:
v8::Isolate* isolate_;
};
@@ -429,6 +431,7 @@
CalcFibAndCheck();
}
}
+
private:
v8::Isolate* isolate_;
};
@@ -498,6 +501,7 @@
thread.Join();
}
}
+
private:
v8::Isolate* isolate1_;
v8::Isolate* isolate2_;
Index: test/cctest/test-threads.cc
===================================================================
--- test/cctest/test-threads.cc (revision 9202)
+++ test/cctest/test-threads.cc (working copy)
@@ -161,6 +161,7 @@
}
semaphore_->Signal();
}
+
private:
i::List<i::ThreadId>* refs_;
int thread_no_;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
