Reviewers: Vitaly Repeshko,
Description:
Fix v8 shared library build by wrapping SourceGroup dtor into an ifndef
V8_SHARED check.
[email protected]
Signed-off-by: Thiago Farina <[email protected]>
Please review this at http://codereview.chromium.org/7860016/
SVN Base: git://github.com/v8/v8.git@bleeding_edge
Affected files:
M src/d8.h
M src/d8.cc
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
160ffa316edf90eac24a5fc62a040e979d82e134..1b6dbe8ca1c4838037e891a1e1946954e15ea345
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -968,6 +968,7 @@ void ShellThread::Run() {
#endif // V8_SHARED
+#ifndef V8_SHARED
SourceGroup::~SourceGroup() {
delete next_semaphore_;
next_semaphore_ = NULL;
@@ -976,7 +977,7 @@ SourceGroup::~SourceGroup() {
delete thread_;
thread_ = NULL;
}
-
+#endif
void SourceGroup::ExitShell(int exit_code) {
// Use _exit instead of exit to avoid races between isolate
Index: src/d8.h
diff --git a/src/d8.h b/src/d8.h
index
c0ef670920e49c9533d6686fc3be2e9beb1fb4bb..e0fbe1883ad21dfc58abcb691e77f693588d4a0a
100644
--- a/src/d8.h
+++ b/src/d8.h
@@ -127,7 +127,9 @@ class SourceGroup {
begin_offset_(0),
end_offset_(0) {}
+#ifndef V8_SHARED
~SourceGroup();
+#endif
void Begin(char** argv, int offset) {
argv_ = const_cast<const char**>(argv);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
