Reviewers: Michael Starzinger,
Description:
NewGC: Clean up a TODO. Make the empty string one of the
immortal immovable objects.
Please review this at http://codereview.chromium.org/7857027/
SVN Base: http://v8.googlecode.com/svn/branches/experimental/gc/
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
===================================================================
--- src/hydrogen-instructions.h (revision 9203)
+++ src/hydrogen-instructions.h (working copy)
@@ -2258,6 +2258,7 @@
if (*handle_ == heap->the_hole_value()) return true;
if (*handle_ == heap->minus_zero_value()) return true;
if (*handle_ == heap->nan_value()) return true;
+ if (*handle_ == heap->empty_string()) return true;
return false;
}
@@ -3342,9 +3343,6 @@
static inline bool StoringValueNeedsWriteBarrier(HValue* value) {
- // TODO(gc) On bleeding edge we omit write barrier when we are
- // storing old space constant. We can't allow such an optimization
- // on GC branch.
return !value->type().IsBoolean()
&& !value->type().IsSmi()
&& !(value->IsConstant() &&
HConstant::cast(value)->ImmortalImmovable());
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
