LGTM (with comments addressed).
http://codereview.chromium.org/7754015/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7754015/diff/1/src/heap.cc#newcode3524 src/heap.cc:3524: MaybeObject* maybe = jsobj->GetHiddenProperties(JSObject::ALLOW_CREATION); Can we move that into a separate method JSObject::SetIdentityHash() to keep the identity hashing code together? http://codereview.chromium.org/7754015/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7754015/diff/1/src/objects.h#newcode1434 src/objects.h:1434: enum CreationFlag { ALLOW_CREATION, OMIT_CREATION }; The use of this flag is ambiguous, it is used to indicate two different things. Can we use two different flags for that purpose? 1) Allow creation of an object holding hidden properties 2) Allow generation of a permanent identity hash code http://codereview.chromium.org/7754015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
