Revision: 9221 Author: [email protected] Date: Mon Sep 12 00:20:42 2011 Log: Fix bogus reset of store buffer top in deserializer.
This was originally introduced in r6201 because the store buffer top is part of the root set and treated as SMI, which in turn causes it to be overwritten by the deserializer. A better fix was introduced in r6443 and skips the entry instead of restoring it after deserialization, thus making this reset obsolete. [email protected] BUG=v8:1562 Review URL: http://codereview.chromium.org/7858035 http://code.google.com/p/v8/source/detail?r=9221 Modified: /branches/experimental/gc/src/serialize.cc ======================================= --- /branches/experimental/gc/src/serialize.cc Mon Aug 29 05:23:10 2011 +++ /branches/experimental/gc/src/serialize.cc Mon Sep 12 00:20:42 2011 @@ -650,8 +650,6 @@ isolate_ = Isolate::Current(); ASSERT(isolate_ != NULL); // Don't GC while deserializing - just expand the heap. - Address* store_buffer_top = - reinterpret_cast<Address*>(isolate_->heap()->store_buffer_top()); AlwaysAllocateScope always_allocate; // Don't use the free lists while deserializing. LinearAllocationScope allocate_linearly; @@ -670,7 +668,6 @@ isolate_->heap()->set_global_contexts_list( isolate_->heap()->undefined_value()); - isolate_->heap()->public_set_store_buffer_top(store_buffer_top); } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
