http://codereview.chromium.org/7865025/diff/2001/src/platform-win32.cc File src/platform-win32.cc (right):
http://codereview.chromium.org/7865025/diff/2001/src/platform-win32.cc#newcode1529 src/platform-win32.cc:1529: } while (result == NULL); this looks too fragile and might go into infinite loop. lets limit number of retries and fallback to "wasteful" allocation if it fails. to make "wasteful" allocation work property we need to track the base pointer to enable correct virtualfree with MEM_RELEASE later (e.g. NewSpace can own base pointer for deallocation of aligned new space chunk; pages can track base pointer in the header. etc.). http://codereview.chromium.org/7865025/diff/2001/src/platform-win32.cc#newcode1552 src/platform-win32.cc:1552: return VirtualFree(base, 0, MEM_DECOMMIT) != 0; Should not it become MEM_RELEASE? http://codereview.chromium.org/7865025/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
