http://codereview.chromium.org/7623011/diff/12001/src/execution.cc File src/execution.cc (right):
http://codereview.chromium.org/7623011/diff/12001/src/execution.cc#newcode165 src/execution.cc:165: // Is there a way to get the proper global object if func is a builtin? On 2011/09/12 14:42:47, Kevin Millikin wrote:
I guess I'm not sure what is proper.
isolate()->global_context()->builtins() is
the builtins object, isolate()->global_object()->global_receiver() is
the global
receiver of the current context.
Ah, thanks, the latter is what I was looking for, but somehow missed. Because func->context()->global()->g_r() gives me the JSBuiltin object if func happens to be a builtin, which would not be good (and breaks one of the tests). Now, the only thing that still puzzles me is how that very logic is used in the generated FunctionApply builtin without causing the same issue... http://codereview.chromium.org/7623011/diff/12001/src/execution.h File src/execution.h (right): http://codereview.chromium.org/7623011/diff/12001/src/execution.h#newcode58 src/execution.h:58: // and object. On 2011/09/12 14:42:47, Kevin Millikin wrote:
"and object" ==> "an object"
Done. http://codereview.chromium.org/7623011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
