LGTM
http://codereview.chromium.org/7780032/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7780032/diff/1/src/d8.cc#newcode1079 src/d8.cc:1079: ShellOptions::~ShellOptions() { nit: To match the order in the .h file this should after the next function. http://codereview.chromium.org/7780032/diff/1/src/d8.cc#newcode1081 src/d8.cc:1081: isolate_sources = NULL; Looks like parallel_files should be deleted as well (when not V8_SHARED). http://codereview.chromium.org/7780032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
