LGTM if you address the comment below:
http://codereview.chromium.org/7891005/diff/4001/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7891005/diff/4001/src/d8.cc#newcode1226 src/d8.cc:1226: i::SmartArrayPointer<char> files; This will delete the contents of |files| when it goes out of scope at the end of the loop. You should change back to plain pointers here (or use files.Detach() in the method call below, but IMHO using plain pointers here is easier). http://codereview.chromium.org/7891005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
