http://codereview.chromium.org/7892013/diff/1/src/execution.cc File src/execution.cc (right):
http://codereview.chromium.org/7892013/diff/1/src/execution.cc#newcode165 src/execution.cc:165: // For reasons that escape me, `global' can be the JSBuiltinsObject On 2011/09/13 17:09:54, Jakob wrote:
It's a nit, but please don't use accents for quoting, that hurts my
eyes. Your
options: - ‘proper’ typographic quotes (bad, because they're non-ASCII
characters and
will confuse some compilers even in comments) - 'regular' ASCII quote/apostrophe replacement characters - the Chromium convention of |pipes| around identifiers in comments.
Done. http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bind-receiver.js File test/mjsunit/regress/regress-bind-receiver.js (right): http://codereview.chromium.org/7892013/diff/1/test/mjsunit/regress/regress-bind-receiver.js#newcode5 test/mjsunit/regress/regress-bind-receiver.js:5: assertEquals(strict.bind(true)(), true); On 2011/09/13 17:09:54, Jakob wrote:
assertEquals takes the expected value as the first parameter and the
actual
value as the second. (Less confusing error messages)++ ;-)
Done. (Had C&P'ed this from Webkit.) http://codereview.chromium.org/7892013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
