Reviewers: Jakob,
Description:
Fixed spurious character in test case, plus presubmit issues.
Also addressed Slava's complaint about the personalized comment.
[email protected]
BUG=
TEST=
Please review this at http://codereview.chromium.org/7886032/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/execution.cc
M test/mjsunit/regress/regress-bind-receiver.js
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index
7ad2dc0be8d5c62b153adf04fdf455a2091db890..7d5f889014a66d8953466c0fe50ae9cc6ca93a02
100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -162,7 +162,7 @@ Handle<Object> Execution::Call(Handle<Object> callable,
!func->shared()->native() && !func->shared()->strict_mode()) {
if (receiver->IsUndefined() || receiver->IsNull()) {
Object* global = func->context()->global()->global_receiver();
- // For reasons that escape me, 'global' can be the JSBuiltinsObject
+ // For somehwat unclear reasons, 'global' can be the JSBuiltinsObject
// under some circumstances. In that case, don't rewrite.
// FWIW, the same holds for
GetIsolate()->global()->global_receiver().
if (!global->IsJSBuiltinsObject()) receiver = Handle<Object>(global);
Index: test/mjsunit/regress/regress-bind-receiver.js
diff --git a/test/mjsunit/regress/regress-bind-receiver.js
b/test/mjsunit/regress/regress-bind-receiver.js
index
19756da1f5fdd43537d5ccd253664c5a1ebf5081..9a39b15129f4edb55b41838576f8352f8337cc5c
100644
--- a/test/mjsunit/regress/regress-bind-receiver.js
+++ b/test/mjsunit/regress/regress-bind-receiver.js
@@ -1,11 +1,41 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Check that modifying an array while sorting it does not segfault. See
+// http://code.google.com/p/chromium/issues/detail?id=66099.
+
function strict() { 'use strict'; return this; }
function lenient() { return this; }
var obj = {};
-
+
assertEquals(true, strict.bind(true)());
assertEquals(42, strict.bind(42)());
assertEquals("", strict.bind("")());
-assertEquals(null, strict.bind(null)()l);
+assertEquals(null, strict.bind(null)());
assertEquals(undefined, strict.bind(undefined)());
assertEquals(obj, strict.bind(obj)());
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
