Reviewers: Vyacheslav Egorov,
Message:
PTAL.
Description:
Fix flags to CollectAllGarbage in API tests.
[email protected]
BUG=v8:1608,v8:1672
TEST=cctest/test-api
Please review this at http://codereview.chromium.org/7888039/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M test/cctest/cctest.status
M test/cctest/test-api.cc
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
f6800543720f8537fd7cca89eb949f67170fcd59..e60eadbac7fd64625b04f8f0870ec90c388856e3
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -53,8 +53,6 @@ test-profile-generator/RecordStackTraceAtStartProfiling:
PASS || FAIL
test-weakmaps/Shrinking: FAIL
# Known failures after merge from the bleeding edge (issue 1672)
-ScriptMakingExternalString: SKIP
-ScriptMakingExternalAsciiString: SKIP
StressJS: SKIP
##############################################################################
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
8771fb313a2682bcb60e572fa3ba0027b58b2a56..366e88049c620771d6fbe5951117c7981eadaafa
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -445,7 +445,8 @@ THREADED_TEST(ScriptMakingExternalString) {
CHECK_EQ(0, dispose_count);
}
i::Isolate::Current()->compilation_cache()->Clear();
- HEAP->CollectAllGarbage(false);
+ // TODO(1608): This should use kAbortIncrementalMarking.
+ HEAP->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);
CHECK_EQ(1, dispose_count);
}
@@ -471,7 +472,8 @@ THREADED_TEST(ScriptMakingExternalAsciiString) {
CHECK_EQ(0, dispose_count);
}
i::Isolate::Current()->compilation_cache()->Clear();
- HEAP->CollectAllGarbage(false);
+ // TODO(1608): This should use kAbortIncrementalMarking.
+ HEAP->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);
CHECK_EQ(1, dispose_count);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
