Revision: 9280
Author: [email protected]
Date: Wed Sep 14 06:48:55 2011
Log: Fix flags to CollectAllGarbage in API tests.
[email protected]
BUG=v8:1608,v8:1672
TEST=cctest/test-api
Review URL: http://codereview.chromium.org/7888039
http://code.google.com/p/v8/source/detail?r=9280
Modified:
/branches/experimental/gc/test/cctest/cctest.status
/branches/experimental/gc/test/cctest/test-api.cc
=======================================
--- /branches/experimental/gc/test/cctest/cctest.status Tue Sep 13 02:59:08
2011
+++ /branches/experimental/gc/test/cctest/cctest.status Wed Sep 14 06:48:55
2011
@@ -53,8 +53,6 @@
test-weakmaps/Shrinking: FAIL
# Known failures after merge from the bleeding edge (issue 1672)
-ScriptMakingExternalString: SKIP
-ScriptMakingExternalAsciiString: SKIP
StressJS: SKIP
##############################################################################
=======================================
--- /branches/experimental/gc/test/cctest/test-api.cc Tue Sep 13 02:59:08
2011
+++ /branches/experimental/gc/test/cctest/test-api.cc Wed Sep 14 06:48:55
2011
@@ -445,7 +445,8 @@
CHECK_EQ(0, dispose_count);
}
i::Isolate::Current()->compilation_cache()->Clear();
- HEAP->CollectAllGarbage(false);
+ // TODO(1608): This should use kAbortIncrementalMarking.
+ HEAP->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);
CHECK_EQ(1, dispose_count);
}
@@ -471,7 +472,8 @@
CHECK_EQ(0, dispose_count);
}
i::Isolate::Current()->compilation_cache()->Clear();
- HEAP->CollectAllGarbage(false);
+ // TODO(1608): This should use kAbortIncrementalMarking.
+ HEAP->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);
CHECK_EQ(1, dispose_count);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
