Updated per review comments. Thanks.

http://codereview.chromium.org/7890001/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

http://codereview.chromium.org/7890001/diff/1/src/mips/code-stubs-mips.cc#newcode1244
src/mips/code-stubs-mips.cc:1244: __ PrepareCallCFunction(0, 2, t4);  //
Two doubles count as 4 arguments.
On 2011/09/14 13:48:57, Erik Corry wrote:
Comment out of date?

Yep, Done.

http://codereview.chromium.org/7890001/diff/1/src/mips/code-stubs-mips.cc#newcode6495
src/mips/code-stubs-mips.cc:6495: // Don't base result on status bits
when a NaN is involved.
On 2011/09/14 13:48:57, Erik Corry wrote:
Comment seems out of date.
Yes, this comment was bad, as were some others nearby, and then I
optimized the code a bit as well. Better now. Thanks.

http://codereview.chromium.org/7890001/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to