Updated those comments. Test coverage is given imo. I'll land.
http://codereview.chromium.org/7832002/diff/1/test/cctest/test-strings.cc File test/cctest/test-strings.cc (right): http://codereview.chromium.org/7832002/diff/1/test/cctest/test-strings.cc#newcode517 test/cctest/test-strings.cc:517: TEST(SliceFromExternal) { On 2011/09/13 18:20:25, Vitaly Repeshko wrote:
Do we have a test for the case of the underlying string changing its
encoding
from ASCII to two-byte?
Both the cctest test-api/MorphCompositeStringTest and the last part of mjsunit/string-slices.js test this. http://codereview.chromium.org/7832002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
