Comment #8 on issue 1646 by [email protected]: Segmentation fault in
v8::internal::Logger::is_logging
http://code.google.com/p/v8/issues/detail?id=1646
I will be sincere telling that I really don't know V8 internals but let me
say that I proposed this fix for two reasons.
The first one is that, taking a look at the crash dump, it really seems to
me the logger is not properly initialized when the crash occurs. Moreover
taking a look at the code it seems like calling
InitializeLoggingAndCounters has no effect if called multiple times.
1646 void Isolate::InitializeLoggingAndCounters() {
1647 if (logger_ == NULL) {
1648 logger_ = new Logger;
1649 }
1650 if (counters_ == NULL) {
1651 counters_ = new Counters;
1652 }
1653 }
I just tried adding that call and the problem disappeared. I'm not
proposing to include this patch as-is because I'm not really understanding
what is causing the bug. What this patch shows is where the bug should
live. So maybe a better way to patch this bug exists. I just wanted to
provide additional details which could turn to be useful.
Thanks and regards,
Angelo
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
