LGTM
http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h File src/frames-inl.h (right): http://codereview.chromium.org/7969013/diff/3003/src/frames-inl.h#newcode108 src/frames-inl.h:108: inline Code* StackFrame::GetContainingCode(Isolate* isolate, Address pc) { Argument variable name should probably something like address instead of pc http://codereview.chromium.org/7969013/diff/3003/src/frames.h File src/frames.h (right): http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode64 src/frames.h:64: Code* GcSafeFindCodeForInnerPointer(Address pc); address instead of pc? http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode65 src/frames.h:65: Code* GcSafeCastToCode(HeapObject* object, Address pc); same as above http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode71 src/frames.h:71: InnerPointerToCodeCacheEntry* GetCacheEntry(Address pc); same as above http://codereview.chromium.org/7969013/diff/3003/src/frames.h#newcode79 src/frames.h:79: InnerPointerToCodeCacheEntry cache_[kPcToCodeCacheSize]; kAddressToCodeCacheSize? http://codereview.chromium.org/7969013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
