Reviewers: Erik Corry,
Description:
Remove incorrect debug-code assertion.
We should not use slot address to find out the page. This does not work for
large pages.
Also this assertion is not always true (violated during incremental
marking).
[email protected]
TEST=mozilla/js1_5/extensions/regress-371636
Please review this at http://codereview.chromium.org/7981001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ia32/macro-assembler-ia32.cc
M src/x64/macro-assembler-x64.cc
Index: src/ia32/macro-assembler-ia32.cc
diff --git a/src/ia32/macro-assembler-ia32.cc
b/src/ia32/macro-assembler-ia32.cc
index
8fbf1faef8191f39322006972cac241bfa90165b..a34faf9a068f44f8d149e3779f2b78251ad810a9
100644
--- a/src/ia32/macro-assembler-ia32.cc
+++ b/src/ia32/macro-assembler-ia32.cc
@@ -84,12 +84,6 @@ void MacroAssembler::RememberedSetHelper(
SaveFPRegsMode save_fp,
MacroAssembler::RememberedSetFinalAction and_then) {
Label done;
- if (FLAG_debug_code) {
- Label ok;
- JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
- int3();
- bind(&ok);
- }
// Load store buffer top.
ExternalReference store_buffer =
ExternalReference::store_buffer_top(isolate());
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index
7570c85bf68ba68f03115f7e3573c610bcb87acf..fba8c9c9ba36dbaa1f3f72660cdf7309ba02e848
100644
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -201,12 +201,6 @@ void MacroAssembler::RememberedSetHelper(Register addr,
Register scratch,
SaveFPRegsMode save_fp,
RememberedSetFinalAction
and_then) {
- if (FLAG_debug_code) {
- Label ok;
- JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
- int3();
- bind(&ok);
- }
// Load store buffer top.
LoadRoot(scratch, Heap::kStoreBufferTopRootIndex);
// Store pointer to buffer.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
